Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup whitespace and new lines in Common props, targets and tasks #6159

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Fixup whitespace and new lines in Common props, targets and tasks #6159

merged 2 commits into from
Mar 4, 2021

Conversation

Nirmal4G
Copy link
Contributor

@Nirmal4G Nirmal4G commented Feb 16, 2021

Part of #4779

Context

Make Common props, targets and tasks easier to read and understand.
Fixup whitespace and new lines only in Common props, targets and tasks files.

Part of the larger refactoring that'll lead into #1686

Changes Made

  • Remove all trailing spaces
  • Fixup new lines where necessary
    • Add new lines between every block to make it clear.
    • Remove unnecessary new lines to reduce scrolling.

Notes

I'll also make sure not to mess up the git blame too much.
To make reviewing easier, I had split up the changes logically rather than a file.
Also, please do note that these changes won't make much difference alone but with other formatting and refactors that follow this will make a world of difference in reading these files.

only in MSBuild Common props, targets and tasks files

Conforming to the repository's EditorConfig file
only in MSBuild Common props, targets and tasks files

Add New Line(s) between every block to make it clear.
Remove unnecessary New Line(s) to reduce scrolling.
@Nirmal4G Nirmal4G changed the title Fixup whitespace and new lines in Common props, targets and tasks files Fixup whitespace and new lines in Common props, targets and tasks Feb 16, 2021
Copy link
Member

@KirillOsenkov KirillOsenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked through and the changes look good to me

@Forgind Forgind added the merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now. label Mar 1, 2021
@benvillalobos benvillalobos merged commit 4144194 into dotnet:master Mar 4, 2021
@Nirmal4G Nirmal4G deleted the hotfix/core-sdk-prep/cleanup-whitespace branch March 4, 2021 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-when-branch-open PRs that are approved, except that there is a problem that means we are not merging stuff right now.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants